search

machinekit / machinetalk-protobuf

Protobuf declarations for machinekit messages
MIT License
10 stars 11 forks source link

Cannot use machinetalk-protobuf in Python without fetching its source #26

Closed bobvanderlinden closed 8 years ago

bobvanderlinden commented 8 years ago

Like Node, Python developers are used to installing packages through pypi using pip install {package}. It would be nice if we could create and publish a Python package for machinetalk-protobuf, so that other projects can depend on this without developers needing to fetch source and install things manually.

machinekoder commented 8 years ago

Never created a PyPi setup but shouldn't be too hard.

bobvanderlinden commented 8 years ago

Here you can find an example of what I did previously to add a setup.py: https://github.com/bobvanderlinden/machinetalk-protobuf/blob/master/python/setup.py

It would also compile the proto files to python, which was based on what the Protobuf library itself did for its setup.py. That can be found here: https://github.com/google/protobuf/blob/master/python/setup.py

machinekoder commented 8 years ago

Thanks, I hope to get this done before the meetup.

machinekoder commented 8 years ago

@bobvanderlinden this was pretty much completed. Why has nobody created a PR yet?

I know this branch also solves the namspacing issue meaning that some modifications are required when the next merge back to Machinekit is done. However, the changes are trivial and very easy to do. Here is my branch with the 2 fixes and rebased to master https://github.com/strahlex/machinetalk-protobuf/tree/python-setup

bobvanderlinden commented 8 years ago

@strahlex Good question. I thought there were some problems with compatiblity (like with nanopb). I apparently only mentioned it in #22 and probably forgot about it when I switched to node and did https://github.com/bobvanderlinden/machinetalk-protobuf-node.

machinekoder commented 8 years ago

Has been merged https://github.com/machinekit/machinetalk-protobuf/pull/36