machinekit / machinetalk-protobuf

Protobuf declarations for machinekit messages
MIT License
10 stars 11 forks source link

Makefile: assignment possible wrong #63

Closed machinekoder closed 8 years ago

machinekoder commented 8 years ago

Most assignments in the Makefile use :=. However, ?= is required in order to take command line arguments. See: http://stackoverflow.com/questions/448910/makefile-variable-assignment

machinekoder commented 8 years ago

e.g. https://github.com/machinekit/machinetalk-protobuf/blob/master/Makefile#L27

mhaberler commented 8 years ago

not needed

?= is just default value setting

machinekoder commented 8 years ago

Without this assignment it is not possible to overwrite the variables. e.g. DESTDIR=/opt/local make does not work.

machinekoder commented 8 years ago

But make DESTDIR=/opt/local does work.