search

machinekit / machinetalk-protobuf

Protobuf declarations for machinekit messages
MIT License
10 stars 11 forks source link

fix docs build #75

Closed machinekoder closed 7 years ago

ArcEye commented 7 years ago

I am travelling at present and won't be able to test and look again at doc builds for a few days.

Currently protobuf build is commented out so will not produce a build yet.

machinekoder commented 7 years ago

No problem.

ArcEye commented 7 years ago

The build still fails in the same place make: *** No rule to make target 'build/python/machinetalk/__init__.py', needed by 'Makefile'. Stop.

This is the original and still unresolved problem with the machinetalk-protobuf docs build.

Since the __init__ files were removed, there is nothing to ensure they are created by setup.py, as the machinekit-docs Makefile just runs make.

AFAICT either there needs to be a static __init__ files, or if they require to be generated to match some namespace requirement, then the Makefile must trigger setup.py with the appropriate switches to ensure they are present.

machinekoder commented 7 years ago

https://github.com/machinekit/machinetalk-protobuf/pull/78 should fix the problem.

ArcEye commented 7 years ago

Yes, that seems to work - well done.