search

machinekit / machinetalk-protobuf

Protobuf declarations for machinekit messages
MIT License
10 stars 11 forks source link

update js bundles #79

Closed machinekoder closed 7 years ago

ArcEye commented 7 years ago

There is a non-fatal warning about potential java outer class name conflict for Firmware since I have been able to build the repo.

Not sure if this can be changed without requiring huge changes to the python naming, so that both use the same call names?

machinekoder commented 7 years ago

This would require the package to be changed to machinetalk.protobuf in the .proto files. It shouldn't have an effect on the Python stuff, however, it would require some changes in the C++ users of Machinetalk. As far as I know, that's only Machinekit and QtQuickVcp so far.

machinekoder commented 7 years ago

At least that's what I think is the source of the warning.

ArcEye commented 7 years ago

The full warning is

[libprotobuf WARNING google/protobuf/compiler/java/java_file.cc:197] machinetalk/protobuf/firmware.proto: 
The default outer class name, "Firmware", conflicts with a type declared in the proto file and an alternative outer class name is used: "FirmwareOuterClass". 
To avoid this warning, please use the java_outer_classname option to specify a different outer class name for the .proto file.

Looking at https://developers.google.com/protocol-buffers/docs/javatutorial it appears that it is just warning you, that it has created a camel-cased java outer casename because one was not supplied, or the supplied one clashed.

I would be loathe to change anything that works currently, just to try an fit in around java more neatly. All these languages assume that only they are in use and make no concessions to try to fit into a multi-language environment.