search

machinelevel / sp425-crazy-cow

Add crude keyboard-lettering function to eink tablet
MIT License
77 stars 6 forks source link

Backspace undo does not seem work #13

Open tobloef opened 2 years ago

tobloef commented 2 years ago

On my reMarkable 1, running 2.10, backspace doesn't seem to press the undo button. It changes the cursor position as you would expect, but the character is not deleted.

I would submit a PR myself, but at the moment I'm stuck on not understanding the coordinate system for pressing the button. The Y coordinate is 12100 (see code here), which I can't really see how maps to pixel coordinates. This makes it hard for me to test if it's the position that is wrong, or if it's something else.

Love the project though, I'm looking forward to hopefully contributing in the future.

machinelevel commented 2 years ago

Thanks for this! Yep, the backspace functionality relies on the "undo" tool, and that's moved. I'll try to get an updated position, or maybe a better option. I'm glad you like the project!

iHnR commented 2 years ago

I would suggest creating a little config file to set the position of the undo tool. I use ddvk hacks, which I believe changes the position of the undo tool as well. This way the user also has the option to do a quick fix if something changes again in the future.