search

machines-in-motion / dynamic_graph_manager

BSD 3-Clause "New" or "Revised" License
4 stars 4 forks source link

Move hardware initialization at the beginning of hardware rt thread #16

Closed jviereck closed 4 years ago

jviereck commented 4 years ago

This allows a pattern where the hardware assumes the hardware loop is run right afterwards. E.g. when launching the master-board and then doing the control right away without launching an extra rt thread for the master-board communication.

MaximilienNaveau commented 4 years ago

I strongly disagree with this. I do not think this is a good idea for real-time-safety reasons. And if you did that because of the master-board-sdk use, I do not think this is a good idea the initialization procedure needs to be updated not this code.

jviereck commented 4 years ago

And if you did that because of the master-board-sdk use, I do not think this is a good idea the initialization procedure needs to be updated not this code.

Okay, thanks for the feedback. I will see if there is an easy way to rewrite the master-board solo8 initialization then.