machines-in-motion / dynamic_graph_manager

BSD 3-Clause "New" or "Revised" License
4 stars 4 forks source link

Mnaveau/python3 #21

Closed MaximilienNaveau closed 4 years ago

MaximilienNaveau commented 4 years ago

Description

Related to this issue: https://github.com/machines-in-motion/dynamic_graph_manager/issues/20 I implemented the needed requirement for the python3 compatibility.

This PR still lacks:

How I Tested

I executed some demos on my laptop... I need more unit-tests for python2/3 compatibility.

Do not merge before

I fulfilled the following requirements

vincentberenz commented 4 years ago

@MaximilienNaveau I'll be on holiday from today, but happy to review as soon I am back (in a week)

MaximilienNaveau commented 4 years ago

@vincentberenz Ok no problem, I will continue a bit on this branch to add unit-tests. These are absolutely lacking in Python so I will build nosetests about the user interface.