rename some demo and install them as shared_memeory_demo_XXX - Githubissues

machines-in-motion / shared_memory

realtime interprocess communication

BSD 3-Clause "New" or "Revised" License

5 stars 1 forks source link

rename some demo and install them as shared_memeory_demo_XXX #26

Closed MaximilienNaveau closed 3 years ago

MaximilienNaveau commented 3 years ago

Description

Remove AMENT dependencies

How I Tested

ran demos and unit-tests on my laptop

I fulfilled the following requirements

[x] All new code is formatted according to our style guide (for C++ run clang-format, for Python, run flake8 and fix all warnings).
[x] All new functions/classes are documented and existing documentation is updated according to changes.
[x] No commented code from testing/debugging is kept (unless there is a good reason to keep it).

vincentberenz commented 3 years ago

Is it correct that the demos are no longer installed in the lib folder, but rather in the bin folder ?

MaximilienNaveau commented 3 years ago

Is it correct that the demos are no longer installed in the lib folder, but rather in the bin folder ?

Yes, it depends what you wanna do:

if you wanna run them simply doing exec_name then you install them in bin.
if you wanna use ros2 run you need to install them in lib/<project_name> and install a package.xml for ros2 to find the installed package. I would recommend to use ament if you intend to depend on ROS2 but again I am not 100% about this.

ROS2 being the particular case (no one is actually using ros except for actually running the robots) I suggest we deal with these cases per package.