fix eigen usage - Githubissues

machines-in-motion / shared_memory

realtime interprocess communication

BSD 3-Clause "New" or "Revised" License

5 stars 1 forks source link

fix eigen usage #28

Closed MaximilienNaveau closed 3 years ago

MaximilienNaveau commented 3 years ago

Description

I am doing this PR because I saw this commit: https://github.com/machines-in-motion/shared_memory/commit/fb3fd4c43908d932f0f662ab3250b8c466d337b8

CMake is now finding the include using the targets. Hence we need to link against all library even if they are headers only.

The reason why it was working is because the include of Eigen (#include <eigen3/Eigen/Core>) was wrong:

1/ This is a hard-coded path to the library installed with Debian (not suitable with other installation patterns).
2/ This is not the include used in the Eigen tutorials: https://eigen.tuxfamily.org/dox/GettingStarted.html

How I Tested

I ran tests and built on my machines, and using the CI in github.

I fulfilled the following requirements

[x] All new code is formatted according to our style guide (for C++ run clang-format, for Python, run flake8 and fix all warnings).
[x] All new functions/classes are documented and existing documentation is updated according to changes.
[x] No commented code from testing/debugging is kept (unless there is a good reason to keep it).