machines-in-motion / shared_memory

realtime interprocess communication

BSD 3-Clause "New" or "Revised" License

5 stars 1 forks source link

Hang up of unit test "exchange_manager" #5

Closed MaximilienNaveau closed 4 years ago

MaximilienNaveau commented 4 years ago

Problem in unitest hanging

The unit-test "exchange_manager" hangs up during the continuous integration and sometimes on my computer too. Which makes the CI fail but with no real information on what failed...

Action taken

I disabled it from the code. One need to investigate the reasons for this hang up.

jviereck commented 4 years ago

Thanks for reporting this Max.

A few things:

in the future, could you point to the PR/commit where you disabled the code? This makes it easier when reading the issue to get the context (in this case the commit is 1).
given that this is crucial for our robot communication, I would voice to make this a P0 bug - inputs?
who is going to track down this bug?
is this a regression - can you find a regression window for this bug?

In case you have troubles to track this down, happy to take a look.

vincentberenz commented 4 years ago

I will look into this today

vincentberenz commented 4 years ago

This issue can be closed after merge:

https://github.com/machines-in-motion/shared_memory/pull/6

MaximilienNaveau commented 4 years ago

This file "include/shared_memory/exchange_manager_memory.hpp" lacks documentation

vincentberenz commented 4 years ago

@MaximilienNaveau exchange_manager_memory.hpp is not part of the API, it is meant to be used internally by exchange_manager_producer/consumer. What I will do: move it to include/shared_memory/internal and set the code in namespace shared_memory::internal. Can we have doxygen skipping include/*/internal in all packages ?

MaximilienNaveau commented 4 years ago

Good thinking. We should also make sure that Catkin does not install the files then. And during the creation of the library you can put the header as source file. So it is embedded in the ".so"