machines-in-motion / shared_memory

realtime interprocess communication

BSD 3-Clause "New" or "Revised" License

5 stars 1 forks source link

unit tests passing #6

Closed vincentberenz closed 4 years ago

vincentberenz commented 4 years ago

exchange manager unit tests

The unit tests for the exchange manager now passes.

Issues lied in the design of the unit test, not in the test it is testing.

Issues were:

no sleep, and sometimes the producer or the consumer was failing to get the lock, and was hanging for too long
producer did not manage well the reset of memory when the consumer dies

new issue : unit test on thread synchronization

The unit tests for thread synchronization was also sometimes hanging. I disabled it and will open an issue.

misc

Various code was updated to remove all compilation warning

MaximilienNaveau commented 4 years ago

[EDIT] 1/ I found out that there was another issue about "hanging" unit-tests in "Shared_memory_tests.test_condition_variable" in the master branch. Is this related to this PR? I do not think so. The error seemed to appear when the library cereal is not found I will do a pull request to fix this.

2/ @vincentberenz can you rebase(or merge if the rebase is too annoying) the master to this branch code so they are compatible? git rebase origin/master fix_unit_tests_exch_manager or git checkout fix_unit_tests_exch_manager git merge origin/master Thanks