machinezone / IXWebSocket

websocket and http client and server library, with TLS support and very few dependencies
BSD 3-Clause "New" or "Revised" License
512 stars 167 forks source link

Fix server empty thread name #478

Closed lanthora closed 11 months ago

lanthora commented 11 months ago

setThreadName in WebSocket::run will overwrite the previously set Srv::ws:, and getUrl is empty at this time, resulting in an empty thread name. For the client, 16 characters are not enough to represent very valid information in Linux. So delete setThreadName in WebSocket::run

bsergean commented 11 months ago

16 chars is not a ton but is useful still, maybe there could be an option to disable this, and we would default it to false to keep the old behavior.

lanthora commented 11 months ago

@bsergean Fix the problem that the server thread name is empty, and keep the old behavior. Add option to disable automatic update of thread name.

bsergean commented 11 months ago

thanks !