allow building when cpp exceptions are disabled

machinezone / IXWebSocket

websocket and http client and server library, with TLS support and very few dependencies

BSD 3-Clause "New" or "Revised" License

539 stars 173 forks source link

allow building when cpp exceptions are disabled #488

Closed arenevier closed 11 months ago

arenevier commented 11 months ago

IXWebSocket needs exceptions support because of the use of stoi. In order to build when cpp exceptions are disabled, we can use strtol when __cpp_exceptions is not set

bsergean commented 11 months ago

Windows / gcc is not happy. Can we switch to your new code all the time ?

arenevier commented 11 months ago

Are you talking about the build error?

 | Cannot find path
 | 'C:\ProgramData\chocolatey\lib\mingw\tools\install\mingw64\x86_64-w64-mingw32\lib\libpthread.dll.a' because it
 | does not exist.

I'm not sure how it can be related to this change.

arenevier commented 11 months ago

Anyway, I have created an alternative pull request with only the exception safe codepath: https://github.com/machinezone/IXWebSocket/pull/489