search

machour / yii2-notifications

A complete notifications module for your Yii 2 powered application
MIT License
90 stars 48 forks source link

Allow customize wrap template #42

Open Eseperio opened 7 years ago

Eseperio commented 7 years ago

https://github.com/machour/yii2-notifications/blob/d21a02b0c894a8ed44c96c40790c7ad47bc42a97/assets/notifications.js#L213

In spite of the listItemTemplate is customizable it is not enough useful, because it is wrapped into a fixed div. When using, as an example, AdminLTE it can´t fit the requirements of this theme, because it requires an unordered list.

Adding a parameter like tagNameor containerTemplate can make it easy to reach.

machour commented 7 years ago

Good catch. I'll gladly merge a PR for this if you want to propose one