search

machty / ember-concurrency-decorators

Task decorators for ember-concurrency 1.x (merged into ember-concurrency 2.0)
MIT License
70 stars 25 forks source link

feat: stage 2 decorators support #28

Closed buschtoens closed 5 years ago

buschtoens commented 5 years ago

This PR builds off of #27 and supersedes it. The intent is to keep support for both, legacy and stage 2 decorators, while also testing both.

buschtoens commented 5 years ago

As soon as https://github.com/ember-decorators/ember-decorators/issues/315 is resolved (by merging and releasing https://github.com/ember-decorators/ember-decorators/pull/316 for instance), this PR could be merged.

Since dependencies from monorepos are not installable straight from GitHub, this PR is annoying to test. If anyone wants to test locally, just remove these lines from node_modules/@ember-decorators/utils/addon/computed.js.

Edit: Turns out, that no upstream changes are required.

buschtoens commented 5 years ago

Depends on https://github.com/ember-decorators/ember-decorators/pull/318

buschtoens commented 5 years ago

Released as 0.4.0.