machty / ember-concurrency-decorators

Task decorators for ember-concurrency 1.x (merged into ember-concurrency 2.0)
MIT License
70 stars 25 forks source link

Task groups don't work with glimmer components #57

Closed jrjohnson closed 4 years ago

jrjohnson commented 5 years ago

I don't know if this belongs here or in the ember-concurrency repo.

Using a taskGroup with a glimmer component throws obj.get is not a function. Comes from here where EmberObject expects get to exist.

import Component from '@glimmer/component';
import { task, taskGroup } from 'ember-concurrency-decorators';

export default class SimpleChart extends Component {
  @taskGroup
  someGroup;
  @task({ group: 'someGroup' })
  *doSomething() {

  }
}
buschtoens commented 4 years ago

Fixed via https://github.com/machty/ember-concurrency/pull/321.

Thanks @jrjohnson!