machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
689 stars 157 forks source link

Revert Ember support #293

Closed simonihmig closed 5 years ago

simonihmig commented 5 years ago

As discussed in #290 this reverts the dropped support for older Ember versions and their test matrix in that PR to cover all the previously supported Ember versions, which were starting at 2.4.

Although the Readme's badge (which was broken) stated support for Ember 1.13, but tests failed for that version. Didn't dig into it, but updated (fixed) the badge with Ember 2.4 as the minimum supported and tested version. Agree?

machty commented 5 years ago

@simonihmig Thank you! So I should release this as 0.10.1?

simonihmig commented 5 years ago

So I should release this as 0.10.1?

@machty So technically this PR does not add anything that the published package would contain, as it only touched the test config and the Readme. But maybe it makes sense to publish it anyways, to at least document it in the Github release page / Changelog that Ember 2.4+ is still officially supported!? In that case 0.10.1 would be appropriate!