search

machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
689 stars 157 forks source link

Consider console error if an exception happens #295

Closed amk221 closed 5 years ago

amk221 commented 5 years ago

I'm new to ember concurrency, and I found it odd that if I don't manually try/catch an error it will be 'lost', or, I won't know about it when a task is run.

Perhaps there could be a console warning to notify in development mode that something has gone awry.

maxfierke commented 5 years ago

Hi @amk221! Generally if you do not handle an error in an ember concurrency task, it should bubble to RSVP.onerror or Ember.onerror and be visible on the browser console.

Can you provide some details on what Ember version and ember-concurrency version you are using? Are you using any error reporting add-ons that might be overriding these handlers?

amk221 commented 5 years ago

👋🏻 I am responding to both those things (for sentry), so I’ll check if there is a miss configuration and get back to you, with a demo repo if necessary. Thanks!

On Mon, 5 Aug 2019 at 17:04, Max Fierke notifications@github.com wrote:

Hi @amk221 https://github.com/amk221! Generally if you do not handle an error in an ember concurrency task, it should bubble to RSVP.onerror or Ember.onerror and be visible on the browser console.

Can you provide some details on what Ember version and ember-concurrency version you are using? Are you using any error reporting add-ons that might be overriding these handlers?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/machty/ember-concurrency/issues/295?email_source=notifications&email_token=AAC5I3MUGW3GLMINIDT6SN3QDBFRVA5CNFSM4HOCUOU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3SJD2I#issuecomment-518296041, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC5I3MNVC63YPIX52FQJULQDBFRVANCNFSM4HOCUOUQ .

amk221 commented 5 years ago

Thanks, was a miss use of allSettled on my part.