Use ember get in case object isn't an EmberObject

machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.

http://ember-concurrency.com

MIT License

689 stars 157 forks source link

Use ember get in case object isn't an EmberObject #321

Closed jrjohnson closed 5 years ago

jrjohnson commented 5 years ago

When using a TaskGroup on an octane glimmer component get does not exist on the component. Ember.get shields us from this and just works.

Fixes machty/ember-concurrency-decorators#57

buschtoens commented 5 years ago

Thanks for fixing this! 👏

jrjohnson commented 5 years ago

Thanks, I very much wanted to add tests @maxfierke, but was daunted by it since EmberObject is pretty deeply embedded in the current tests and in things like Task. Finally decided to just go with the obvious quick fix especially given other work like #302 that seems to address this issue head on.