Closed Turbo87 closed 4 years ago
Seems to be triggered by this: https://github.com/machty/ember-concurrency/blob/a863f4172fca5a63104054ff7a7aa41796a41380/addon/-scheduler.js#L54
Mind giving this branch a try: https://github.com/machty/ember-concurrency/pull/338 ?
I been seeing this issue too.
That branch fixes it, I have to use it now or can't release.
I'm having issues with the test for the fix for it on earlier Ember versions in the CI matrix, but I'll try to fix that up tonight and tag a release. I do not recommend using a branch in production.
@maxfierke it might be possible to remove the test file from the broccoli tree depending on the ember version, but I have to admit that I'm not sure how exactly to do that either 😅
I mean.. I can't not use the branch it literally breaks everything.
that double negation is hard to parse 😅
I'm seeing something similar:
It's on "numQueued".
Versions:
"ember-concurrency": "^1.1.5",
"ember-concurrency-decorators": "^1.0.0",
code:
export default class FindModalSplit extends Helper {
/**
* Task that wraps async call to get modal-split record from store
*/
@task *findModalSplitTask(geoid) {
return yield [
this.readonlyStore.find('ACS-modal-split', geoid),
this.readonlyStore.find('CTPP-modal-split', geoid),
];
}
/**
* Main helper 'compute' function
*/
compute(params) {
const [geoid] = params;
if (!geoid) return null;
return this.findModalSplitTask.perform(geoid);
}
}
@allthesignals can you confirm there are no addons depending on earlier versions of ember-concurrency that might be getting used instead?
@maxfierke that was totally it! time to add https://github.com/salsify/ember-cli-dependency-lint to this project...
appreciate it :)
We tried to update our app to Ember 3.15 this morning and the test suite of one of our apps uncovered the following issue:
I haven't been able to come up with a reproduction yet, but I'll update this issue if I can provide one.