machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
690 stars 157 forks source link

Deprecate direct usage of task with action helper and disable tests for it on 3.20+ #372

Closed maxfierke closed 4 years ago

maxfierke commented 4 years ago

This feature unfortunately depends on private APIs that will be removed in Ember 3.25. Unfortunately, the mechanism was already removed in Ember 3.20, making it impossible to support this for releases at least until recent canaries where it was re-introduced with a deprecation. However, the feature is rarely used, only documented in the changelog, and frequently breaks whenever the private constant it depends on moves modules internally throughout new versions of Ember.

It will continue to remain available for Ember < 3.20, but will not be available in Ember-Concurrency 2.0, and will show a deprecation warning from 1.3.0 forward.

Also, fixes the failing TypeScript tests, affecting other in-progress PRs #365 & #368