During the re-implementation of encapsulated tasks for v2, I made a few errors:
Encapsulated state was not made available for access outside of the encapsulated task
Encapsulated state was not made per-instance, but rather shared in a singleton fashion for the whole task. This could likely cause subtle bugs (though, probably a bit less likely given no external access was implemented.)
This addresses both by moving the encapsulated task state instantiation to the same time as when the TaskInstance is created and performed, and allows us to wrap that same TaskInstance and forward non-existing property gets to the encapsulated task state. This is slightly different than v1, which used the EmberObject mixin system to mixin the encapsulated task into a new class definition. Mixins aren't functionality available to us with native classes, but instead the Proxy provides a safer way to do it by not allowing overriding of Task or TaskInstance internals.
Caveats: this does use Proxy and WeakMap for supporting reads of the encapsulated task state via the TaskInstance. However, Proxy and WeakMap are both at ~95% support on caniuse, so it seems pretty safe. Should work fine w/ the existing polyfills out there too, if needed.
During the re-implementation of encapsulated tasks for v2, I made a few errors:
This addresses both by moving the encapsulated task state instantiation to the same time as when the TaskInstance is created and performed, and allows us to wrap that same TaskInstance and forward non-existing property gets to the encapsulated task state. This is slightly different than v1, which used the EmberObject mixin system to mixin the encapsulated task into a new class definition. Mixins aren't functionality available to us with native classes, but instead the Proxy provides a safer way to do it by not allowing overriding of Task or TaskInstance internals.
Caveats: this does use
ProxyandWeakMapfor supporting reads of the encapsulated task state via the TaskInstance. However,ProxyandWeakMapare both at ~95% support on caniuse, so it seems pretty safe. Should work fine w/ the existing polyfills out there too, if needed.