machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
691 stars 157 forks source link

Update Ember QUnit to V5 #410

Closed alexlafroscia closed 3 years ago

alexlafroscia commented 3 years ago

I did this locally as part of investigating #409, and figured it would be worthwhile to up-stream this dependency bump since there are some set-up changes that are also required.

alexlafroscia commented 3 years ago

The yarn.lock change here is wild -- seems like a lot of Babel dependencies being updated to their latest versions and stuff like that.

maxfierke commented 3 years ago

@alexlafroscia mind running yarn-deduplicate on that? might cleanup some of the noise in yarn.lock

alexlafroscia commented 3 years ago

Can do! I ran it specifically for the Babel dependencies locally and it helped a bit. I'll run it for the whole file and push that up!

alexlafroscia commented 3 years ago

That helped a bunch! It's still a whole lot of additions, but at least there's like 800LOC of removals too.

alexlafroscia commented 3 years ago

Yup! That just happened so I'll do that update

alexlafroscia commented 3 years ago

Much better diff numbers!