search

machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
691 stars 157 forks source link

Correctly import from private task-instance #411

Closed mydea closed 3 years ago

mydea commented 3 years ago

In my typescript app I noticed these warnings:

WARNING in ./node_modules/ember-concurrency/-task-instance.js 4:15-27
"export 'default' (imported as 'TaskInstance') was not found in './-private/task-instance'
@ ./assets/my-app.js

WARNING in ./node_modules/ember-concurrency/index.js 11:0-378
"export 'default' (reexported as 'TaskInstance') was not found in './-private/task-instance'
@ ./node_modules/ember-power-select/components/power-select.js
@ ./assets/my-app.js

So I went and looked, and it seems they were incorrectly importing the default instead of named export. I guess this isn't used anywhere, as otherwise it should have broken (?) somehow. I fixed the imports here.