machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
691 stars 157 forks source link

WIP: Resolve Async Error Handling Issues #412

Closed alexlafroscia closed 3 years ago

alexlafroscia commented 3 years ago

For now, this PR adds a probably-too-specific test for an error-handling error that I encounter in my app, by recreating the exact situation where it fails (in that the error catching is inside a helper, inside an Integration test)

I'm not sure yet what exactly a minimal reproduction looks like that could be done as a unit test.

Note: this includes #410 since the latest ember-qunit version was required to trigger the error

I also updated ember-source, thinking that might be part of the problem since this addon is using a slightly older version. Updating that didn't start to surface the bug (I tried it before updating the test dependencies) but since I know the bug is reproducible with that version, I left the bump in this PR. We should drop that commit before this PR lands.

Related to #409