Remove runloop binding for perform helper

machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.

http://ember-concurrency.com

MIT License

691 stars 157 forks source link

Remove runloop binding for perform helper #414

Closed maxfierke closed 3 years ago

maxfierke commented 3 years ago

Wrapping perform in a full runloop means that a synchronous task throw will be reported within that same invocation, before another helper is able to wrap and instrument the task instance. Since it's already run, it's too late to do things like attaching catch handlers. We do not need this runloop binding anymore, since there's no auto-run assertion with the versions supported by ember-concurrency 2.x.

Fixes #409

maxfierke commented 3 years ago

@alexlafroscia mind giving this a spin against your app to see if it resolves the problem "in the wild", so to speak?

alexlafroscia commented 3 years ago

Can do! I'll check this branch out tomorrow and see what happens