search

machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
691 stars 155 forks source link

Fix waitForProperty types, uncomment type tests #479

Closed machty closed 5 months ago

machty commented 1 year ago

As part of the work for version 2.3 I forgot that when I bumped some dependencies, I started getting some type failures in tests/types/ember-concurrency-test.ts, so I commented those tests out.

This PR attempts to

  1. re-enable those specs
  2. Fix the waitForProperty type to allow for the 3rd arg to be optional
machty commented 1 year ago

I'm not sure what dependency might have changed that caused things to break, but here's the package.json diff: https://gist.github.com/machty/8394d88d2f9f29630ec0dd1e8c48fd6b

image

Note that the type seem correct when doing app development, just that the expect-types package we use for testing is considering these type assertions invalid as part of the upgrade to 2.3.0.