search

machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
689 stars 157 forks source link

The new API doesn't seem to work with ember-cli-code-coverage #483

Closed mayatron closed 2 years ago

mayatron commented 2 years ago

The new api doesn't seem to work with the latest ember-cli-code-coverage@2.0.0-beta.4 when running with COVERAGE=true. See this issue I just filed: https://github.com/kategengler/ember-cli-code-coverage/issues/361

I suspect this is an issue with the code coverage addon and not this one, but I thought it might be useful to mention here in case others are stumbling into this.

Btw, the new api is really nice. 🚀 Thanks!

machty commented 2 years ago

@mayatron can you try changing your ember-concurrency in package.json to "https://github.com/machty/ember-concurrency.git#maybe-fix-code-coverage"? Trying to see whether #490 fixes the issue.

mayatron commented 2 years ago

@mayatron can you try changing your ember-concurrency in package.json to "https://github.com/machty/ember-concurrency.git#maybe-fix-code-coverage"? Trying to see whether #490 fixes the issue.

Tested, and works for me!

machty commented 2 years ago

Fixed in 2.3.5

olyckne commented 2 years ago

Hm, still doesn't work here on 2.3.5. Tried with both ember-cli-code-coverage@1.0.3 and 2.0.0-beta.4

Same issue on a new ember app Made a reproduction repo here: https://github.com/olyckne/ember-concurrency-arrow-fn-code-coverage-issue

machty commented 2 years ago

@olyckne thank you for the repro, I believe I narrowed it down in #492. Can you give that PR a try in your app?

olyckne commented 2 years ago

@machty yes! That works both in my app and the reproduction repo! :tada:

machty commented 2 years ago

Fixed in 2.3.6