search

machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
691 stars 155 forks source link

Minor typo in 2.3.2 release notes #484

Closed mydea closed 1 year ago

mydea commented 1 year ago

Just a small heads up, the codemod usage in the GH release for 2.3.2 is slightly wrong, it says:

But should be **/*.ts / **/*.js - at least without that, it errors for me :) May be nice to update this in the release, as I wondered initially why it wasn't working :sweat_smile:

(Although that didn't work out for me as well, but that is a different topic - I opened an issue over at the codemod repo https://github.com/machty/ember-concurrency-codemods/issues/1)

Thank you for the great work! The async tasks are awesome!

machty commented 1 year ago

I updated the instructions with syntax that should work across zsh/bash. Either way, depending on whether you're codemodding apps or addons you'll need to decide which inputs/files to run the codemods on, and that'll be an exercise left to the user.