Ember 4 Upgrade - Githubissues

machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.

http://ember-concurrency.com

MIT License

691 stars 155 forks source link

Ember 4 Upgrade #515

Closed elwayman02 closed 1 year ago

elwayman02 commented 1 year ago

Bump to latest github action versions
Add Ember 4.4 scenario, drop scenarios below 3.28
Switch from npm-run-all to concurrently
Add ember-source peerDep
Add node 18 support
ember-modifier v3 (v4 is available but may require additional migration work)
Added ember-sinon-qunit to make sinon play nice with ember-auto-import
Bump volta to latest node/yarn minor/patch versions
Convert assert.equal to assert.strictEqual or assert.deepEqual
Autofix additional lint errors and disable 2 rules with weird errors
Update caniuselist db

1..197
# tests 197
# pass  196
# skip  1
# todo  0
# fail  0

# ok

elwayman02 commented 1 year ago

Actually, I believe ember-qunit and some other dependencies are finally forcing a drop of support for <3.28. I'll go ahead and remove these scenarios as it was going to be a major version bump anyway, and it's probably about time to drop support for Ember versions that have long been EOL'd. If you feel strongly that those scenarios need to be maintained still, I'm open to you pushing the proper changes to this branch to keep them working. 👍

elwayman02 commented 1 year ago

We can probably drop node 10/12 support as well as part of this major release. What do you think?

SergeAstapov commented 1 year ago

We can probably drop node 10/12 support as well as part of this major release. What do you think?

@elwayman02 we should do it in a separate PR, right?

elwayman02 commented 1 year ago

Yea, it doesn't have to be done in this PR as long as the CI builds pass once someone enables them.

On Mon, Mar 27, 2023 at 7:37 AM Sergey Astapov @.***> wrote:

We can probably drop node 10/12 support as well as part of this major release. What do you think?

@elwayman02 https://github.com/elwayman02 we should do it in a separate PR, right?

— Reply to this email directly, view it on GitHub https://github.com/machty/ember-concurrency/pull/515#issuecomment-1485232457, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKDTKU3S5NSM4WUWWF4LDTW6GQZDANCNFSM6AAAAAAWEQGQCE . You are receiving this because you were mentioned.Message ID: @.***>

elwayman02 commented 1 year ago

@machty are you able to take a look at this? It would be great to get tests actively running against an explicit 4.x LTS scenario soon. :)