machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
691 stars 155 forks source link

Fix code blocks not rendering on documentation site #522

Closed camerondubas closed 1 year ago

camerondubas commented 1 year ago

Code blocks on https://ember-concurrency.com/docs/tutorial are not rendering. This is due to deprecated code in the CodeSnippet component's template (provided by ember-code-snippet).

To solve this, I bumped to thes latest ember-code-snippet, which required adding and configuring ember-prism as well as creating a local CodeSnippet component as this is no longer provided by ember-code-snippet directly.

Additionally, the calculation of the max height for the template-toggle component broke so I refactored to use ResizeObserver.

Here are a couple of updated screenshots. Note that the styling is a bit different from before. This can be customized, however, I felt this could be addressed in a follow-up PR. image image

Closes https://github.com/machty/ember-concurrency/issues/521