search

machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
691 stars 155 forks source link

Fix this is undefined in benchmark.js #526

Open ombr opened 1 year ago

ombr commented 1 year ago

Benchmark task-modifier was not working out of the box on my tasks. I had to make sure we are using the right this. I was inspired by what is done in ember-concurrency-retryable:

https://github.com/maxfierke/ember-concurrency-retryable/blob/4b18ccc073872d8a7592c4f1eb6c17461938334b/addon/-private/retryable-task-instance.js#L72

machty commented 5 months ago

I am interested in merging this... if you have time could you "rebase" against master? You'd have to move the code changes to the packages/test-app folder.