search

machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
691 stars 155 forks source link

Export types for helpers #532

Open Techn1x opened 1 year ago

Techn1x commented 1 year ago

Follows on from this other issue, but it's closed since the author figured out a workaround - but I do think this addon should export types for helpers. https://github.com/machty/ember-concurrency/issues/530

With Glint entering 1.0 and more applications adopting it, it's very useful to export these types as they end up being used in typed glint .gts files.

perform helper being the main example here. The other 2 helpers may not be much of a priority, not sure how widely used they are.

Looks like there's a type file declared here, if it helps! https://github.com/Gavant/glint-template-types/blob/main/types/ember-concurrency/perform.d.ts

bartocc commented 6 months ago

I agree, it would be great to have ember-concurrency export the helper types instead of having to rely on @gavant/glint-template-types