search

machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
691 stars 155 forks source link

Fix CI build #537

Closed bendemboski closed 11 months ago

bendemboski commented 11 months ago

Something (probably a release of new embroider packages) caused most of the floating dependencies scenarios to start failing in all branches. It looks like it was some kind of mismatch between the version of @embroider/macros used by @ember/render-modifiers (a dependency of ember-prism) and whatever version of @embroider/shared-internals it was finding in the node_modules tree.

So this commit updates us to the latest @embroider/macros, which allows us to dedupe @embroider/macros and @embroider/shared-internals, which appears to fix the issue.

bendemboski commented 11 months ago

The embroider-safe and embroider-optimized failures were happening in master before the failures this PR addressed started happening, so I believe this PR makes sense to merge as-is because it addresses one (newer) issue even though it doesn't address the other (older/pre-existing) issue.