search

machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.
http://ember-concurrency.com
MIT License
691 stars 155 forks source link

Simplify ts snippets by using the same import statements for `import Component from `@glimmer/component` #567

Closed johanrd closed 4 months ago

johanrd commented 4 months ago

Currently, all three ts-snippets had different ways of importing Component:

https://github.com/machty/ember-concurrency/blob/8e0c0379d6fa99a38c137ddd16345c60ebd3abba/packages/test-app/snippets/ts/basic-example.ts#L1

https://github.com/machty/ember-concurrency/blob/8e0c0379d6fa99a38c137ddd16345c60ebd3abba/packages/test-app/snippets/ts/template-import-example.txt#L1

https://github.com/machty/ember-concurrency/blob/8e0c0379d6fa99a38c137ddd16345c60ebd3abba/packages/test-app/snippets/ts/typing-task.ts#L1

The third one is the "standard" way, from the ember guides, so I changed the first two to align with that.