Make glint template an optional peer dependency

machty / ember-concurrency

ember-concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks.

http://ember-concurrency.com

MIT License

691 stars 155 forks source link

Make glint template an optional peer dependency #572

Closed LucasHillDex closed 3 months ago

LucasHillDex commented 4 months ago

See issue: https://github.com/machty/ember-concurrency/issues/570

All other ember projects that have @glint/template as a peer dependency have it as optional as far as I can find. We are not using glint, and this imports types that cause issues in our codebase.

LucasHillDex commented 3 months ago

Curious if you have any feedback @machty thanks!

machty commented 3 months ago

@LucasHillDex happy to merge! Could you resolve prettier failures?

LucasHillDex commented 3 months ago

@machty CI didn't kick off but I think I fixed it, thanks!

machty commented 3 months ago

Thank you!

machty commented 3 months ago

Released in 4.0.2