search

machty / ember-navigator

A better router/navigator for mobile Ember apps, inspired by React Navigation
Other
30 stars 3 forks source link

Drop knowledge of "header"-related properties #10

Open lukemelia opened 4 years ago

lukemelia commented 4 years ago

Various parts of ember-navigator (including StackRouter and MountedRouter) deal with headerMode and headerComponent properties. IMHO, these are non-essential to ember-navigator and are relatively easy to support in user-land, so they should be removed from ember-navigator.

lukemelia commented 4 years ago

I see that React Navigation does include these concepts, so dropping them would be straying from that API. I still stand by my view as noted, just wanted to flag this.

lukemelia commented 4 years ago

Per discussion with @machty, we'll proceed to a PR that removes these.