machty / emblem-brunch

Emblem.js for Brunch.io
7 stars 13 forks source link

Use configurable file paths for all libraries #2

Closed valpackett closed 11 years ago

valpackett commented 11 years ago

and fix the readme and stuff.

machty commented 11 years ago

Thanks for putting this together. Does the code provide for a way to compile a non-emberized template?

I see @window.Emblem.precompile @window.Ember.Handlebars, data, what would be nice is if you could detect if the filename had the pattern of .raw.emblem, which would trigger it to pass @window.Handlebars instead of Ember.Handlebars, which is how a raw Handlebars template is rendered. Should be pretty trivial since all the other hard parts are in place... would you mind putting that in there?

machty commented 11 years ago

Perhaps another idea would be if you don't provide an Ember path, all .emblem templates are assumed to be raw handlebars, rather than necessitating .raw.emblem to be in the name. I'd be happy w/ that, but you guys are more familiar with the brunch patterns than I

valpackett commented 11 years ago

I'll do this in my fork, good idea

On Feb 22, 2013, at 5:46 AM, Alex Matchneer notifications@github.com wrote:

Perhaps another idea would be if you don't provide an Ember path, all .emblem templates are assumed to be raw handlebars, rather than necessitating .raw.emblem to be in the name. I'd be happy w/ that, but you guys are more familiar with the brunch patterns than I

— Reply to this email directly or view it on GitHub.

machty commented 11 years ago

Could you update the test suite to test for both emberized and raw handlebars? Should be pretty trivial but we need that in there as a baseline.

machty commented 11 years ago

yo yo yo what's the status on all this?

foxyblocks commented 11 years ago

I think it should include default dependencies and use the path options as overrides. Less configuration for noobs.

machty commented 11 years ago

@myfreeweb is this ready to merge?

valpackett commented 11 years ago

yes

On Feb 27, 2013, at 9:48 PM, Alex Matchneer notifications@github.com wrote:

@myfreeweb is this ready to merge?

— Reply to this email directly or view it on GitHub.