search

machty / emblem.js

Emblem.js - Ember-friendly, indented syntax alternative for Handlebars.js
http://emblemjs.com
MIT License
1.04k stars 81 forks source link

Upgrade Handlebars 2.0.0 #179

Closed saponifi3d closed 10 years ago

saponifi3d commented 10 years ago

Fix for #175

This will upgrade to use Handlebars 2.0.0, upgrades the version of Ember which supports Handlebars 2.0.0.

Also, did some modifications so things like ember-template-compiler.js is just using the node module for easy updating. Followed the standard of committing the compiled files, although you may want to remove those from the repo so there are smaller change sets.

Lastly, there were a number of lint errors that I went through and cleaned up. Cheers! :beers:

machty commented 10 years ago

Very cool! Seems to be working!

http://jsbin.com/wotev/2/edit

machty commented 10 years ago

Do you see any reason why I shouldn't 1.0.0 this thing?

saponifi3d commented 10 years ago

Not really, I wasn't sure what version you wanted to make it so i didn't mess with the version number.

The only place i'm a little concerned about the change is https://github.com/machty/emblem.js/pull/179/files#diff-193bef935ffd0dc8256ff86ed41d0638R38 but that was required to keep precompile working the way ember / emblem expect the results.

Thanks for being so responsive throughout the work on this!!

saponifi3d commented 9 years ago

Any word on the version number bump and pushing it to npm? looking to upgrade https://github.com/phvcky/gulp-emblem/issues/13 and https://github.com/modalstudios/rendr-emblem with this version of emblem too.

coladarci commented 9 years ago

Would love for a release with this as I'm itching to try out ember canary htmlbars! Great work..