search

machty / emblem.js

Emblem.js - Ember-friendly, indented syntax alternative for Handlebars.js
http://emblemjs.com
MIT License
1.04k stars 81 forks source link

Deploy master to NPM #197

Closed saponifi3d closed 9 years ago

saponifi3d commented 9 years ago

@machty - would it be possible to put what is currently master on NPM - the conversion to handlebars 2.0.0 will solve a lot of bugs that keep happening w/ emblem. (I'm also waiting for it to update gulp-emblem and grunt-emblem for handlebars 2.0.0).

Thanks :)

machty commented 9 years ago

Done, lemme know if I messed something up

saponifi3d commented 9 years ago

:D thanks!!!

bjornstar commented 9 years ago

Changing handlebars 1.3.0 to 2.0.0 is not a patch level change. Please delete 0.3.19 from npm and release it as 0.4.0 so that people still stuck on handlebars 1.3.0 can use 0.3.x and people in the modern age can use 0.4.x for handlebars 2.0.0

Also, please add a tag to the repo for 0.4.0 when you release that.

bantic commented 9 years ago

@bjornstar 0.3.19 doesn't target Handlebars 2.0.0. That support is coming, but it is not in master yet.

bantic commented 9 years ago

@bjornstar Nope, I'm wrong, sorry: https://github.com/machty/emblem.js/commit/54d4e8759a078eb01f4a85e6bf572eeaf449b406