0.5.0 beta - Githubissues

machty / emblem.js

Emblem.js - Ember-friendly, indented syntax alternative for Handlebars.js

http://emblemjs.com

MIT License

1.04k stars 81 forks source link

0.5.0 beta #206

Closed mixonic closed 9 years ago

mixonic commented 9 years ago

This branch will merge into master, then become 0.5.0.

Please see https://github.com/machty/emblem.js/pull/196 for context. The 0.5.0 release will dramatically change the way Emblem works- it will change from a Handlebars AST-compatible compiler into a template printer.

This release will break support for "vanilla" Handlebars. See VANILLA_HANDLEBARS.md for ideas on how we can re-introduce this with a later release.
Ember-CLI apps should use 0.5.0 with the ember-cli-emblem-hbs-printer addon. A 0.1.0 version will be released after Emblem is released.
This branch will need a manual merge. The diff is so large that rebase gets confused about how the files should be renamed. A merge should go smoothly though.

mixonic commented 9 years ago

All issues on the 0.5.0 milestone are closed. This is ready to merge @machty!

mixonic commented 9 years ago

Whoops, I lied. Adding two issues now.

mixonic commented 9 years ago

Merged! Woo!

coladarci commented 9 years ago

:+1: :+1:

coladarci commented 9 years ago

Very excited to try this out - we have a huge emblem project that has a brutally slow template.. With this gemfile:

gem 'ember-rails', '0.16.1'
gem 'ember-source', '1.10.0'
gem 'emblem-rails', '0.2.1'
gem 'emblem-source', github: 'machty/emblem.js',     branch: 'master'
gem 'barber-emblem', github: 'machty/barber-emblem', branch: 'master'

When I recompile assets, I get this error:

Compiler said: ReferenceError: Can't find variable: Handlebars

Looks like someone, somewhere, isn't using HTMLBars and I don't have the background to really understand where to start looking. Any help?

Really really appreciate this re-write...

bantic commented 9 years ago

@coladarci I believe we'll need some additional work to update the emblem-source gem as well. We're tracking this in #216

coladarci commented 9 years ago

Thanks @bantic - exciting stuff.....

josemarluedke commented 9 years ago

Awesome work guys! Very exited!!! Thanks for your hard work.