machty / emblem.js

Emblem.js - Ember-friendly, indented syntax alternative for Handlebars.js
http://emblemjs.com
MIT License
1.04k stars 81 forks source link

Glimmer components #272

Closed thec0keman closed 8 years ago

thec0keman commented 8 years ago

Depends on #271 and #270

Fixes #240

thec0keman commented 8 years ago

@machty I could use your advice on how to move forward with this branch. I think the refactoring was important for making the glimmer component logic work, but it also helped clarify the overall logic a good deal for me. As a result, in the process of working on it it made several bug fixes trivial. (And unfortunately, it would take some extra work to backport them to a pre-refactor version).

I would really like to see the bugfixes and refactoring merged. As far as I know, the work on glimmer components is in line with the current syntax, but I don't think much more can be done until the Ember team finalizes that syntax. I think there is a good case for merging the current work, but with the obvious understanding that as the syntax finalizes some changes may need to be made.

What would you like to see from this branch to get it merged? If it would help I can split up this branch into its different parts (bugs, refactoring, etc.).

Thanks!

machty commented 8 years ago

@thec0keman could you e-mail me at machty@gmail.com? I'd like to discuss giving you commit bit for this repo :)