search

machulav / ec2-github-runner

On-demand self-hosted AWS EC2 runner for GitHub Actions
MIT License
747 stars 337 forks source link

Error regarding ec2 os input #176

Open danielMCF99 opened 11 months ago

danielMCF99 commented 11 months ago

Hi. I copied the code present here https://github.com/marketplace/actions/on-demand-self-hosted-aws-ec2-runner-for-github-actions-with-windows-support for a github workflow file and it gives me an error regarding de ec2 os action input. When looking at the action.yaml, there is nothing regarding the OS field. Is the action documentation out of date?

jeff-m-sullivan commented 9 months ago

Just want to point out that the action you're referencing is a fork maintained by someone else, but I think I see the problem.

The sample code specifies a Linux runner using ec2-base-os while the documentation has a parameter with a slightly different name:

ec2-os Optional. Used only with the start mode. Base OS type of the EC2 image (AMI). This defaults to Linux. The new runner needs to be configured based on OS:- windows- linux

Given that the code in that fork specifies the parameter as ec2-os, it seems like the sample code there is out-of-date.