machyve / xhyve

xhyve, a lightweight OS X virtualization solution
Other
6.44k stars 353 forks source link

Migrate vmm_callout -> OSX libdispatch #112

Closed bonifaido closed 2 years ago

bonifaido commented 8 years ago

Tries to be a cleaner implementation then the current one, based upon what I saw in README.md - TODO I thought it was a good idea to migrate it. I wouldn't say it is complete, but it could be a good starting point. I haven't seen any issues by running a VM for a couple of hours with multiple sleeps with this patch.

jeremyhu commented 5 years ago

Have you done any performance comparisons before and after your changes?

bonifaido commented 5 years ago

Just rebased on master.

bonifaido commented 5 years ago

Tried the Tiny Linux boot, and it still works with the rebased version.

I have run performance tests in the past (2 years ago) and they looked better than the original implementation (and if I just could remember how did I they looked like!). What would you suggest, how to exercise it? I think it would make sense to test it again.

bonifaido commented 3 years ago

@machyve/write-access do you think this still something that is worth to merge? I can try to spend some time on it to get it tested again.

yurikoles commented 3 years ago

@bonifaido it seems like project is semi-dead.

catap commented 2 years ago

@jeremyhu can you take a look on this?