machyve / xhyve

xhyve, a lightweight OS X virtualization solution

Other

6.44k stars 356 forks source link

fix: #164 virtio-net + UEFI crash #189

Open amartinunowhy opened 4 years ago

amartinunowhy commented 4 years ago

When using virtio-net with an UEFI firmware (bootrom), xhyve crashes on an assertion. See the related bug

164

The complete details are not clear to me, but it seems that during boot, the firmware reads on the interface but doesn't provide big enough read buffers. It seems that the space for VLAN headers is missing.

This patch drops the related reads, so normal booting can occur. Network boot probably doesn't work, though.

Signed-off-by: Antoine Martin amartin@unowhy.com

mike-pt commented 4 years ago

thanks for this: I tested and at least now it moves along, but its like you say:

Read buffer too small: 1514 bytes. vmnet expected at least 1518. (thanks for printing that too btw)

Seems like the real solution is finding why its smaller right?

Still this is great for now