search

machyve / xhyve

xhyve, a lightweight OS X virtualization solution
Other
6.43k stars 353 forks source link

don't care about "Don't Care" bits #211

Closed julien-oster closed 3 years ago

julien-oster commented 3 years ago

The previous code cared about Don't Care bits in capability fields for controls by terminating with an error when encountering any unknown ones. This causes problems on newer CPUs, which add new such bits for new features. It is safe and recommended to simply retain the current value in the respective control for such bits, and this change does that. Some rearchitecting was needed, because the previous code treated the capabilities as global.

jasnee commented 3 years ago

Thanks, Julien. Was able to boot tinycore without running into the vmx flag error.