search

maciej7777 / PrometheeDiviz

Introduces new Promethee modules for Diviz system.
MIT License
1 stars 1 forks source link

[PROMSORT] incomparable relation is misisng #11

Open davejm95 opened 12 months ago

davejm95 commented 12 months ago

https://github.com/maciej7777/PrometheeDiviz/blob/master/PROMETHEE-PROMSORT_assignments/src/pl/poznan/put/promethee/Promsort.java

The method seems to be incorrectly implemented. The incomparable relation is missing in the code. When running the program in diviz, this results in alternatives incomparable to the limit profiles always being assigned to a worse class already in the first step assignments, no matter parameter b. This is not how the method works and also makes no sense in practice. See the incomparable relation original paper: https://www.sciencedirect.com/science/article/pii/S0925527306002131 The incomparable relation should probably be inserted in the "isA1IndifferencedToA2" function on line 44

maciej7777 commented 11 months ago

Hi Dave, thank you for creating an issue for this problem! I will take a look on this when I find some more time (which may take longer then just few days - as I am no longer a student). But for sure I will do my best to fix the problem in reasonable time.