maciejhirsz / kobold

Easy declarative web interfaces.
https://docs.rs/kobold/
Mozilla Public License 2.0
385 stars 7 forks source link

Refer user to Trunk website installation instructions since they vary depending on the user's OS #17

Closed ltfschoen closed 1 year ago

ltfschoen commented 1 year ago

I noticed when I was following the installation instructions in the README.md file that some of the steps to install Trunk aren't the same as the installation instructions at https://trunkrs.dev/#install. If they didn't go to https://trunkrs.dev/#install and just assumed that following the README.md instructions were sufficient they might give up if they were inexperienced or have an Apple M1 or were using macOS.

Suggest removing the README.md instruction cargo install --locked trunk and instead just referring the user to go to https://trunkrs.dev/#install and follow the instructions there, where there are OS-specific instructions.

I think it's fine to leave trunk serve in the README.md file since I'd expect that to be common across different OSes

maciejhirsz commented 1 year ago

Good catch, will get it fixed first thing in the morning.