maciejhirsz / kobold

Easy declarative web interfaces.
https://docs.rs/kobold/
Mozilla Public License 2.0
385 stars 7 forks source link

error[E0658]: use of unstable library feature 'toowned_clone_into': recently added #26

Closed ltfschoen closed 1 year ago

ltfschoen commented 1 year ago

In the commit '576495100f3d7fc4ec93b621cbdfee8295648145' of this fork https://github.com/**ltfschoen/kobold where I've rebased with the latest commit in 'master' branch commit '53eacf69d2ea3f25a47e58a3ccd11dcaf73d48bf' of maciejhirsz/kobold**. If I run trunk serve when using the latest "nightly" version with rustup override set nightly-2022-03-22-x86_64-unknown-linux-gnu it gives the following error when i run trunk serve due to the use of clone_into:

Screen Shot 2023-03-17 at 10 27 03 pm

But if I use the latest "stable" version with rustup override set stable-x86_64-unknown-linux-gnu it doesn't produce any error when i run trunk serve.

To fix the error in "nightly" it was necessary to add #![feature(toowned_clone_into)] to the crate attributes at the top of the following files:

Whilst I suspect we'd only be using the "stable" Rust version in this repo, is there a reason why we wouldn't want to create a PR into this repo to use #![feature(toowned_clone_into)] so it resolved the error error[E0658]: use of unstable library feature 'toowned_clone_into': recently added that is caused by the use of clone_into in a few places, so that this repo builds successfully for users that are using Rust "nightly"?

maciejhirsz commented 1 year ago

I left a comment on #23 so you wouldn't reopen it. You need to update your Rust :upside_down_face:.

ltfschoen commented 1 year ago

thanks! yes i understand now, it appears i wasn't noticing the difference between 22 and 23 in nightly-2022 vs nightly-2023