ltfschoen
commented
1 year ago currently getting errors like the following when i try updating the "details" table a few times. it's also updating 'main' in localstorage instead of 'details' key
Uncaught RuntimeError: memory access out of bounds
at __wbindgen_describe___wbg_onwebkitanimationend_dc7fa17c9bb3d099 (gen_Window.rs:4)
at _$LT$kobold..list..List$LT$T$GT$$u20$as$u20$kobold..View$GT$::update::h2b41b999ffff549b (list.rs:67)
at __wbindgen_describe___wbg_setonwebkittransitionend_0bf670694051a5f2 (gen_Window.rs:4)
at wasm_bindgen::describe::inform::h1d4130bc30aa8346 (describe.rs:53)
at __wbindgen_describe___wbg_onwebkitanimationstart_d5dde6955c300832 (gen_Window.rs:4)
at fast_qr::compact::CompactQR::push_u8::h737e828197cd41d4 (compact.rs:156)
at fast_qr::compact::CompactQR::push_bits::hdd53cfa98552c26d (compact.rs:197)
at fast_qr::encode::encode_numeric::encode_number::h4aed989c5b47f87d (encode.rs:69)
at _$LT$core..str..iter..Chars$u20$as$u20$core..iter..traits..iterator..Iterator$GT$::next::h13225b9c692b5ae1 (iter.rs:44)
at _$LT$core..str..pattern..StrSearcher$u20$as$u20$core..str..pattern..Searcher$GT$::next::h9cc018efeec93740 (pattern.rs:1079)
at core::ptr::read::heb129bd681cea205 (mod.rs:1158)
at core::mem::transmute_copy::hd8719058fc1c85b7 (mod.rs:1063)
at console_error_panic_hook::hook_impl::h6677313f5d604aac (lib.rs:112)
at fast_qr::datamasking::mask_5_6::hbcce44575688bf6e (datamasking.rs:115)
at kobold_invoice.js:129:45
$_ZN8dlmalloc8dlmalloc5Chunk33set_size_and_pinuse_of_free_chunk17h9a71603b7f779266E @ gen_Window.rs:4
$_ZN8dlmalloc8dlmalloc17Dlmalloc$LT$A$GT$4free17h3c328ae7ee80e465E @ list.rs:67
$__rdl_dealloc @ gen_Window.rs:4
$__rust_dealloc @ describe.rs:53
$_ZN63_$LT$alloc..alloc..Global$u20$as$u20$core..alloc..Allocator$GT$10deallocate17h36ef018e6a61c91aE @ compact.rs:156
$_ZN5alloc5alloc8box_free17h6e91f12b737fcd30E @ iter.rs:44
$_ZN4core3ptr165drop_in_place$LT$alloc..boxed..Box$LT$dyn$u20$core..ops..function..Fn$LT$$LP$web_sys..features..gen_Event..Event$C$$RP$$GT$$u2b$Output$u20$$u3d$$u20$$LP$$RP$$GT$$GT$17ha448bf1c2f11e487E @ mod.rs:1158
$_ZN4core3mem4drop17h2c037c55273e5525E @ lib.rs:112
$_ZN133_$LT$dyn$u20$core..ops..function..Fn$LT$$LP$A$C$$RP$$GT$$u2b$Output$u20$$u3d$$u20$R$u20$as$u20$wasm_bindgen..closure..WasmClosure$GT$8describe7destroy17hf6ab3bf8da6b9a64E @ datamasking.rs:115
(anonymous) @ kobold_invoice.js:129
kobold_invoice.js:102 Uncaught TypeError: Failed to execute 'decode' on 'TextDecoder': The encoded data was not valid.
at getStringFromWasm0 (kobold_invoice.js:102:30)
at imports.wbg.__wbg_createTextNode_2112894c86841cbb (kobold_invoice.js:364:45)
at fast_qr::default::create_matrix_alignments::hcee1ddb1085e5459 (default.rs:149)
at _ZN76_$LT$$RF$kobold..diff..Ref$LT$str$GT$$u20$as$u20$kobold..value..IntoText$GT$9into_text17hb11f50f01c8b6fabE (kobold_invoice_bg.wasm:0xb479e)
at fast_qr::default::create_matrix_alignments::hcee1ddb1085e5459 (kobold_invoice_bg.wasm:0xad553)
at fast_qr::polynomials::structure::hb4b1448fb5c928fe (polynomials.rs:129)
at _$LT$kobold..list..List$LT$T$GT$$u20$as$u20$kobold..View$GT$::update::h9fa55b396af89e38 (list.rs:66)
at _$LT$core..slice..iter..IterMut$LT$T$GT$$u20$as$u20$core..iter..traits..iterator..Iterator$GT$::next::hdfa3ff59ae353b75 (macros.rs:142)
at alloc::vec::Vec$LT$T$C$A$GT$::push::ha74b3facff6165fb (mod.rs:1844)
at wasm_logger::Style::new::h729c9f0071af9b02 (lib.rs:80)
mod.rs:2637 Uncaught RuntimeError: memory access out of bounds
at _$LT$alloc..vec..Vec$LT$T$C$A$GT$$u20$as$u20$core..ops..deref..Deref$GT$::deref::h23ff83151ef2245b (mod.rs:2637)
at wasm_bindgen_futures::task::singlethread::Task::into_raw_waker::raw_wake_by_ref::h40c29e0c999635df (singlethread.rs:72)
at __wbindgen_describe___wbg_ontransitionstart_9c839e3817f89ed7 (gen_Window.rs:4)
at __wbindgen_describe___wbg_ontransitionend_d3cd710b8bede9b4 (gen_Window.rs:4)
at fast_qr::datamasking::mask_vertical::hcf9f883b6f47a9e4 (datamasking.rs:59)
at _$LT$alloc..alloc..Global$u20$as$u20$core..alloc..Allocator$GT$::allocate::h700939757b68bd88 (alloc.rs:238)
at passStringToWasm0 (kobold_invoice.js:56:15)
at imports.wbg.__wbg_value_1f2c9e357d18d3ea (kobold_invoice.js:475:22)
at fast_qr::default::create_matrix_pattern::h3b5a361121530954 (default.rs:95)
at _ZN4main11CellDetails6render28_$u7b$$u7b$closure$u7d$$u7d$17hdf11d6f6d856e2c8E (kobold_invoice_bg.wasm:0x6aa6f)
run with
from_org_addrinput field in the UIfrom_org_addrinput field in the UI with multiple editable input fields with details likeinv_date,from_org_addr, etc (from details.csv labels. so we can choose a 'details' file details.csv to populate those input fields in the UI, whose input fields are still then editableEmpty, try usingcondition.then(|| view! { ... })https://doc.rust-lang.org/std/primitive.bool.html#method.then. See Discord thread "how to useEmpty...". Update: did this to conditionally render the hint only when not already editingupdateinstead ofupdate_silentagain.onload_detailsandonload_maininto common method, or move common aspects into common function. See https://github.com/maciejhirsz/kobold/commit/1cc4c97ec6859fdc025ecb20552247265ef29244. See Discord thread "how to change the onchange...". Update: This feature is only possible with nightly, might be possible in futureonchange(until refresh or upload a different document), but the issue doesn't happen on Firefox - solved using this https://stackoverflow.com/a/48499451/3208553, in this commit https://github.com/maciejhirsz/kobold/pull/57/commits/daa517a11e44eebca0869d0aa4859ccc065a6a18onchangeto something else so if try upload same file twice in a row on Brave or Chrome, it updates#details,name,age\nluke,...., where there is a mapping fromdetailstoTableVariant::Details. so if they provide a valid one identified by prefix with#at the start, then it will store that valuedetailsas theTable's propertyvariantvalue, otherwise it will error if invalid one is provided, or if it is not provided thenTableVariant::Unknownwill be stored (perhaps if loaded from mock data) unless they click the relevant button that triggers sayonload_details, which manually overrides it withTableVariant::Detailswithget(state).table.variant = table_variant;Table's propertyvariantvalue has a value other thanTableVariant::Unknown, so if it wasTableVariant::Detailsthen it'd modify the string to be downloaded so it would be prefixed with#details,before anything else. See commit https://github.com/maciejhirsz/kobold/commit/8eb05e176ef41fbc9021997cd5d408334f5d1030HeadDetailswe useEditing::Cell { row, col }whereas inHeadwe just use(Editing::Column { col }. In the state for "details" table we're storing thevariablesin columns, thedatain row[0], and the labels in row[1], but we want the variables removed, the labels to be instead in row[0] and data values in row[1]. In csv.rs we're pushing the table variant prefix on the variables in details, but we're pushing the table variant prefix on the labels in main because it doesn't have any variables. it's inconsistent but it still works, but need to remove variables and only keep labels. fixed in commit https://github.com/maciejhirsz/kobold/pull/57/commits/8e1fd25edf6f58f8368c1c9f360cb7dbd696b766"description,total,qr,aaa\neat,1,0x0,\nsleep,2,0x1,") then pad those values so do not get errors saving. See commit https://github.com/maciejhirsz/kobold/pull/57/commits/79433ce608012cfd4231d5b9b88e59914344202fonload_commonwith Maciej feedback to pass function to the function as follows:and call with
onload_common(|state| &mut state.main, state, event).await;to duplicateonload_common, so the closure will be inlined in the release build. also replacewith the following as they should compile to the same code with optimizations on, which is an extra layer of a state machine for the compiler to chug through:
InvalidRowLength. but also give option to specify the table variant#main, or#details, we know where they should go in the UI. error if try upload two files both with same variant..... would it be cooler if they were in same file, but that's not a very organised approach#value into aconst, but not sure how to use the const in a regex so would have to change that manually. also wouldn't mind creating a mapping from TableVariant to string by creating a FromTableVariant that extends String, and also the other way arround. Also think i need to have higher order Error enum since some errors might have shared usage across state.rs and csv.rs files . Draft commit with TODOs here https://github.com/maciejhirsz/kobold/commit/8eb05e176ef41fbc9021997cd5d408334f5d1030HeadandHeadDetailsinto single componentHead, and combineCellwithCellDetailsinto a single componentCell. Do this by usingget: impl Fn(&mut State) -> &mut Contentinstead ofstate: ...techniqueScreenshot Preview (9 May 2023):
Screenshot Preview (8 May 2023):